Add custom schema handling logic to directives that rename columns #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrangler-core/src/main/java/io/cdap/directives/column/CleanseColumnNames.java
Outdated
Show resolved
Hide resolved
wrangler-core/src/main/java/io/cdap/directives/column/SetHeader.java
Outdated
Show resolved
Hide resolved
vanathi-g
force-pushed
the
schema-directive-changes
branch
2 times, most recently
from
6f3642f
to
0477f5c
Compare
saimukkamala
approved these changes
Aug 9, 2023
| List<Schema.Field> fields = new ArrayList<>(context.getInputSchema().getFields()); | ||
| for (int i = 0; i < columns.size(); i++) { | ||
| Schema.Field existing = fields.remove(i); | ||
| fields.add(i, Schema.Field.of(columns.get(i), existing.getSchema())); |
There was a problem hiding this comment.
- Will there be a case where number of elements in
columnsare greater than number of elements ininputSchema? in that case,existing.getSchema()might throw aNullPointerException? - Why are we removing and adding elements to existing input schema rather than creating a new list? if we can, then we should for readability.
saimukkamala
reviewed
Aug 9, 2023
wrangler-core/src/main/java/io/cdap/directives/column/SetHeader.java
Outdated
Show resolved
Hide resolved
wrangler-core/src/main/java/io/cdap/directives/column/SetHeader.java
Outdated
Show resolved
Hide resolved
…anse-column-names' directives
vanathi-g
force-pushed
the
schema-directive-changes
branch
from
df77cf8
to
ef41631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
rename,set-headers,swap,cleanse-columnsdirectives