-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler e2e tests #666
Merged
itsankit-google
merged 1 commit into
data-integrations:develop
from
priyabhatnagar25:Wrangler-parsing-2
Jan 24, 2024
+1,162
−152
Merged
wrangler e2e tests #666
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
wrangler-transform/src/e2e-test/features/Wrangler/ParseAsExcel.feature
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # Copyright © 2023 Cask Data, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| # use this file except in compliance with the License. You may obtain a copy of | ||
| # the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations under | ||
| # the License. | ||
|
|
||
| @Wrangler | ||
| Feature: Parse as excel | ||
|
|
||
| @GCS_SOURCE_TEST @BQ_SINK_TEST | ||
| Scenario: To verify User is able to run a pipeline using parse Excel directive | ||
| Given Open Datafusion Project to configure pipeline | ||
| Then Click on the Plus Green Button to import the pipelines | ||
| Then Select the file for importing the pipeline for the plugin "Directive_parse_excel" | ||
| Then Navigate to the properties page of plugin: "GCSFile" | ||
| Then Replace input plugin property: "project" with value: "projectId" | ||
| Then Replace input plugin property: "path" with value: "gcsSourceBucket" | ||
| Then Close the Plugin Properties page | ||
| Then Navigate to the properties page of plugin: "BigQuery" | ||
| Then Replace input plugin property: "project" with value: "projectId" | ||
| Then Replace input plugin property: "table" with value: "bqTargetTable" | ||
| Then Replace input plugin property: "dataset" with value: "dataset" | ||
| Then Validate "BigQuery" plugin properties | ||
| Then Close the Plugin Properties page | ||
| Then Rename the pipeline | ||
| Then Deploy the pipeline | ||
| Then Run the Pipeline in Runtime | ||
| Then Wait till pipeline is in running state | ||
| Then Open and capture logs | ||
| Then Verify the pipeline status is "Succeeded" | ||
| Then Close the pipeline logs | ||
| Then Validate The Data From BQ To BQ With Actual And Expected File for: "ExpectedDirective_parse_excel" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
wrangler-transform/src/e2e-test/features/Wrangler/ParseAsJson.feature
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Copyright © 2023 Cask Data, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| # use this file except in compliance with the License. You may obtain a copy of | ||
| # the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations under | ||
| # the License. | ||
|
|
||
| @Wrangler | ||
| Feature: parse as Json | ||
|
|
||
| @BQ_SOURCE_JSON_TEST @BQ_SOURCE_TEST @BQ_SINK_TEST | ||
| Scenario: To verify User is able to run a pipeline using parse Json directive | ||
| Given Open Datafusion Project to configure pipeline | ||
| Then Click on the Plus Green Button to import the pipelines | ||
| Then Select the file for importing the pipeline for the plugin "Directive_parse_json" | ||
| Then Navigate to the properties page of plugin: "BigQueryTable" | ||
| Then Replace input plugin property: "project" with value: "projectId" | ||
| Then Replace input plugin property: "dataset" with value: "dataset" | ||
| Then Replace input plugin property: "table" with value: "bqSourceTable" | ||
| Then Click on the Get Schema button | ||
| Then Validate "BigQueryTable" plugin properties | ||
| Then Close the Plugin Properties page | ||
| Then Navigate to the properties page of plugin: "BigQuery2" | ||
| Then Replace input plugin property: "project" with value: "projectId" | ||
| Then Replace input plugin property: "table" with value: "bqTargetTable" | ||
| Then Replace input plugin property: "dataset" with value: "dataset" | ||
| Then Validate "BigQuery2" plugin properties | ||
| Then Close the Plugin Properties page | ||
| Then Rename the pipeline | ||
| Then Deploy the pipeline | ||
| Then Run the Pipeline in Runtime | ||
| Then Wait till pipeline is in running state | ||
| Then Open and capture logs | ||
| Then Verify the pipeline status is "Succeeded" | ||
| Then Close the pipeline logs | ||
| Then Validate The Data From BQ To BQ With Actual And Expected File for: "ExpectedDirective_parse_json" |
43 changes: 43 additions & 0 deletions
43
wrangler-transform/src/e2e-test/features/Wrangler/ParseAsXmlToJson.feature
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Copyright © 2023 Cask Data, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| # use this file except in compliance with the License. You may obtain a copy of | ||
| # the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations under | ||
| # the License. | ||
|
|
||
| @Wrangler | ||
| Feature: parse as XmlToJson | ||
|
|
||
| @BQ_SOURCE_XML_TEST @BQ_SOURCE_TEST @BQ_SINK_TEST | ||
| Scenario: To verify User is able to run a pipeline using parse XmlToJson directive | ||
| Given Open Datafusion Project to configure pipeline | ||
| Then Click on the Plus Green Button to import the pipelines | ||
| Then Select the file for importing the pipeline for the plugin "Directive_parse_xml" | ||
| Then Navigate to the properties page of plugin: "BigQueryTable" | ||
| Then Replace input plugin property: "project" with value: "projectId" | ||
| Then Replace input plugin property: "dataset" with value: "dataset" | ||
| Then Replace input plugin property: "table" with value: "bqSourceTable" | ||
| Then Click on the Get Schema button | ||
| Then Validate "BigQueryTable" plugin properties | ||
| Then Close the Plugin Properties page | ||
| Then Navigate to the properties page of plugin: "BigQuery2" | ||
| Then Replace input plugin property: "project" with value: "projectId" | ||
| Then Replace input plugin property: "table" with value: "bqTargetTable" | ||
| Then Replace input plugin property: "dataset" with value: "dataset" | ||
| Then Validate "BigQuery2" plugin properties | ||
| Then Close the Plugin Properties page | ||
| Then Rename the pipeline | ||
| Then Deploy the pipeline | ||
| Then Run the Pipeline in Runtime | ||
| Then Wait till pipeline is in running state | ||
| Then Open and capture logs | ||
| Then Verify the pipeline status is "Succeeded" | ||
| Then Close the pipeline logs | ||
| Then Validate The Data From BQ To BQ With Actual And Expected File for: "ExpectedDirective_parse_xml" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the pipelines are exported.In almost all the PR's the issue is when we try to get schema then randomly in most of the fields it is going null when we click on get schema and validate button. And it also changes the schema . So just to solve that issue we removed that part from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by this?
Can you please elaborate with the help of screenshots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the schema and validation step.