Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLUGIN-1755: Use Kryo for serialisation #710

Merged
merged 1 commit into from
Apr 30, 2024
Merged

PLUGIN-1755: Use Kryo for serialisation #710

merged 1 commit into from
Apr 30, 2024

Conversation

samdgupi
Copy link
Contributor

@samdgupi samdgupi commented Apr 29, 2024

This change adds the support to serialize and deserialize wrangler Row objects using Kryo. This is used while communicating with TaskWorker to execute directives.

  1. We have to register all classes to be serialized with Kryo. The list of this class is taken from SchemaConverter
  2. Kryo is not thread safe hence each serializer uses its own instance
  3. The version of Kryo is kept same as CDAP

We will feature gate it in a future PR

Copy link
Contributor

@tivv tivv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given a feature gate is added

@samdgupi samdgupi merged commit aadb82b into develop Apr 30, 2024
4 of 5 checks passed
@samdgupi samdgupi deleted the plugin-1755 branch April 30, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers unit test build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants