Merge pull request #464 from data-to-insight/fix/combine-header-la-is…

…sues issues_df without header issues
data-to-insight · Sep 29, 2023 · 864115e · 864115e
2 parents ca17120 + 74c8120
commit 864115e
Show file tree

Hide file tree

Showing 3 changed files with 126 additions and 3 deletions.
diff --git a/cin_validator/cin_validator.py b/cin_validator/cin_validator.py
@@ -284,10 +284,14 @@ def __init__(
         )
         self.full_issue_df.reset_index(drop=True, inplace=True)
 
-        # combine multichild issues
+        # remove header issues from main dataframe and transfer to no-child-id dataframe
         header_issues = self.full_issue_df[
             self.full_issue_df["tables_affected"] == "Header"
         ]
+        self.full_issue_df = self.full_issue_df[
+            self.full_issue_df["tables_affected"] != "Header"
+        ]
+        # combine multichild issues
         self.multichild_issues = pd.concat([header_issues, self.la_rule_issues])[
             ["rule_code", "rule_description"]
         ]

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -10,9 +10,12 @@ packages = [
 
 [tool.poetry.dependencies]
 python = "^3.9"
-pandas = "1.5.3"
+pandas = "^1.4.2"
 govuk-bank-holidays = "^0.13"
 testfixtures = "^7.1.0"
+prpc-python = "^0.9.2"
+click-log = "^0.4.0"
+rich = "^13.5.3"
 
 [tool.poetry.dev-dependencies]
 pytest = "^7.1.3"