⚓ all: minor cleanup

database64128 · Aug 25, 2024 · cc29c1f · cc29c1f
1 parent 91a8ff4
commit cc29c1f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/cmd/shadowsocks-go-domain-set-converter/main.go b/cmd/shadowsocks-go-domain-set-converter/main.go
@@ -132,7 +132,7 @@ func DomainSetBuilderFromDlc(text string) (domainset.Builder, error) {
 
 		end := strings.IndexByte(line, '@')
 		if end == 0 {
-			return dsb, fmt.Errorf("invalid line: %s", line)
+			return dsb, fmt.Errorf("invalid line: %q", line)
 		}
 
 		if *tag == "" { // select all lines
@@ -159,7 +159,7 @@ func DomainSetBuilderFromDlc(text string) (domainset.Builder, error) {
 		case strings.HasPrefix(line, regexpPrefix):
 			dsb.RegexpMatcherBuilder().Insert(line[regexpPrefixLen:end])
 		default:
-			return dsb, fmt.Errorf("invalid line: %s", line)
+			return dsb, fmt.Errorf("invalid line: %q", line)
 		}
 	}
 

diff --git a/domainset/domainset.go b/domainset/domainset.go
@@ -145,7 +145,7 @@ func (dsb Builder) WriteText(w io.Writer) error {
 	regexpCount, regexpSeq := dsb.RegexpMatcherBuilder().Rules()
 	capacityHint := fmt.Sprintf("%s%d %d %d %d %s\n", capacityHintPrefix, domainCount, suffixCount, keywordCount, regexpCount, capacityHintSuffix)
 
-	bw := bufio.NewWriter(w)
+	bw := bufio.NewWriterSize(w, 128*1024)
 	if _, err := bw.WriteString(capacityHint); err != nil {
 		return err
 	}

diff --git a/mmap/mmap_test.go b/mmap/mmap_test.go
@@ -11,7 +11,6 @@ func TestReadFile(t *testing.T) {
 		t.Fatal(err)
 	}
 	name := f.Name()
-	defer os.Remove(name)
 
 	_, err = f.WriteString(name)
 	f.Close()