feat: re-export types, runtime-api, and version from client and server crates#90
Conversation
…r crates Applications using `databend-meta-client` or `databend-meta` can now access `types`, `runtime_api`, and `version` through the main crate re-exports, eliminating the need to add these as separate dependencies in `Cargo.toml`. The server's `version` module is renamed to `raft_version` to avoid conflicting with the re-exported `databend_meta_version` crate. The redundant `pub use databend_meta_version::MIN_CLIENT_VERSION` is removed since it's now available directly via `crate::version`.
xp-trumpet
left a comment
xp-trumpet
left a comment
There was a problem hiding this comment.
@xp-trumpet partially reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on drmingdrmer).
There was a problem hiding this comment.
Pull request overview
This PR adds convenience re-exports of the types, runtime_api, and version crates from both the databend-meta-client and databend-meta (server) crates. This allows downstream consumers to access these dependencies through the main crate re-exports rather than adding them as separate Cargo.toml entries. The server's internal version module is renamed to raft_version to avoid a naming conflict with the new databend_meta_version re-export.
Changes:
- Re-export
databend_meta_runtime_api,databend_meta_types, anddatabend_meta_versionasruntime_api,types, andversionfrom both the client and server crates. - Rename the server's
versionmodule toraft_versionto avoid conflicting with the re-exporteddatabend_meta_versioncrate. - Remove the now-redundant
pub use databend_meta_version::MIN_CLIENT_VERSIONfromraft_version.rs, sinceMIN_CLIENT_VERSIONis accessible via the re-exportedcrate::version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/client/client/src/lib.rs |
Adds pub extern crate re-exports for runtime_api, types, and version. |
crates/server/service/src/lib.rs |
Adds pub extern crate re-exports for runtime_api, types, and version; renames pub mod version to pub mod raft_version. |
crates/server/service/src/raft_version.rs |
Removes the now-redundant pub use databend_meta_version::MIN_CLIENT_VERSION re-export. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changelog
feat: re-export types, runtime-api, and version from client and server crates
Applications using
databend-meta-clientordatabend-metacan now accesstypes,runtime_api, andversionthrough the main crate re-exports,eliminating the need to add these as separate dependencies in
Cargo.toml.The server's
versionmodule is renamed toraft_versionto avoidconflicting with the re-exported
databend_meta_versioncrate. Theredundant
pub use databend_meta_version::MIN_CLIENT_VERSIONis removedsince it's now available directly via
crate::version.