Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: at most one snapshot is written for one table in multi statement transaction #16011

Closed
wants to merge 13 commits into from

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Jul 10, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

If a table is updated multiple times in a mutli statement transaction, only one snapshot should be written to storage layer. This PR maintains a property: For any snapshot s, s.prev != null => s.prev must have been successfully committed, which will be the basis of the new vacuum protocol

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 10, 2024
@SkyFan2002 SkyFan2002 marked this pull request as ready for review July 12, 2024 01:45
@SkyFan2002 SkyFan2002 requested review from dantengsky and zhyass July 12, 2024 01:45
@SkyFan2002 SkyFan2002 marked this pull request as draft July 13, 2024 09:34
@SkyFan2002 SkyFan2002 closed this Jul 14, 2024
@SkyFan2002
Copy link
Member Author

replaced by #16044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant