Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify vacuum drop table handling #16446

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 12, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: simplify vacuum drop table handling

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 12, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review September 12, 2024 12:00
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. A-query Area: databend query labels Sep 12, 2024
@SkyFan2002
Copy link
Member

Would you like to add some documentation comments to the functions get_drop_table_infos(), do_get_table_history(),get_gc_table_info(),batch_filter_table_info()? which would make it more friendly to read.@drmingdrmer

@drmingdrmer
Copy link
Member Author

Would you like to add some documentation comments to the functions get_drop_table_infos(), do_get_table_history(),get_gc_table_info(),batch_filter_table_info()? which would make it more friendly to read.@drmingdrmer

Yes I will do so, comment is always very important for teamwork. but I still don't fully understand how it works yet. :(

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
@drmingdrmer drmingdrmer merged commit d78d7bc into databendlabs:main Sep 12, 2024
95 of 96 checks passed
@drmingdrmer drmingdrmer deleted the 141-refactor-vacuum branch September 12, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants