Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multi-thread recreate view/table gives error #16465

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Sep 18, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

When executing DROP TABLE IF EXISTS, if the table metadata contains a drop_on flag, indicating that the table has already been marked for deletion, no error will be returned. This ensures the operation is idempotent, preventing unnecessary errors from being raised if the table has already been dropped.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 18, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 18, 2024
@dosubot dosubot bot added the A-meta Area: databend meta serive label Sep 18, 2024
@zhyass zhyass changed the title fix: Multi-thread recreate view gives error fix: Multi-thread recreate view/table gives error Sep 18, 2024
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dantengsky and @sundy-li)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2024
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dantengsky and @sundy-li)

@drmingdrmer
Copy link
Member

Nice shot!

@zhyass zhyass added this pull request to the merge queue Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
* fix: Multi-thread recreate view gives error

* fix test
Merged via the queue into databendlabs:main with commit 047f081 Sep 19, 2024
82 checks passed
@zhyass zhyass deleted the feature_fix branch September 19, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: databend meta serive lgtm This PR has been approved by a maintainer pr-bugfix this PR patches a bug in codebase size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Multi-thread recreate view gives error
2 participants