Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: direct io syscall not available on mac #16574

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Oct 9, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Direct io syscall not available on mac, so we need a fallback.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test (Cross-platform issues)

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 9, 2024
@xudong963 xudong963 marked this pull request as ready for review October 9, 2024 07:08
@xudong963 xudong963 added this pull request to the merge queue Oct 9, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Oct 9, 2024
@BohuTANG BohuTANG merged commit add514c into databendlabs:main Oct 9, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants