Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): use arrow-flight to exchange datas #16657

Merged
merged 18 commits into from
Oct 23, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Oct 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Migrate exchange common-arrow flight to arrow-flight.

Note:
This change is incompatible if you are running nodes with old versions and new versions in the same cluster, because the old version does not recognize the new compression types.

You can use set global query_flight_compression = 'none' if you still want to have different query version nodes in the same cluster.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Oct 22, 2024
@sundy-li sundy-li added the incompat incompatible changes label Oct 22, 2024
@sundy-li sundy-li added the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Oct 23, 2024
Copy link
Contributor

Docker Image for PR

  • tag: pr-16657-4485a16-1729644215

note: this image tag is only available for internal use,
please check the internal doc for more details.

@sundy-li sundy-li added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@sundy-li sundy-li removed the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Oct 23, 2024
@sundy-li sundy-li added this pull request to the merge queue Oct 23, 2024
Merged via the queue into databendlabs:main with commit 92248e1 Oct 23, 2024
72 of 73 checks passed
@sundy-li sundy-li deleted the flight-arrow branch October 23, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompat incompatible changes pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants