-
Notifications
You must be signed in to change notification settings - Fork 843
refactor: build the runtime filter during the HashJoin block collection process #19058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Docker Image for PR
|
Contributor
Docker Image for PR
|
Contributor
Docker Image for PR
|
zhang2014
approved these changes
Dec 8, 2025
zhang2014
reviewed
Dec 8, 2025
zhang2014
reviewed
Dec 8, 2025
Co-authored-by: Winter Zhang <coswde@gmail.com>
Contributor
Docker Image for PR
|
Contributor
Docker Image for PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-cloud
Build docker image for cloud test
pr-refactor
this PR changes the code base without new features or bugfix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
build the runtime filter during the HashJoin block collection process, so that this part of the computation can be naturally parallelized.
before:

after:
Refactored the concurrent Bloom filter construction: now it is built concurrently using atomic variables, replacing the previous approach where each thread built its own filter and the results were merged afterward.
Tests
Type of change
This change is