feat: impl DisplayUnixTimeStampExt for Option<Duration>#10
Merged
drmingdrmer merged 2 commits intodatabendlabs:mainfrom Feb 17, 2026
Merged
feat: impl DisplayUnixTimeStampExt for Option<Duration>#10drmingdrmer merged 2 commits intodatabendlabs:mainfrom
DisplayUnixTimeStampExt for Option<Duration>#10drmingdrmer merged 2 commits intodatabendlabs:mainfrom
Conversation
Timestamps are often optional (e.g., "last seen at"), so accepting
`Option<Duration>` directly avoids callers needing to unwrap before
formatting. `None` renders as the literal string `"None"`, matching the
convention used by `DisplayOption`.
Internally, `DisplayUnixTimeStamp::duration` is now `Option<Duration>`;
the `Display` impl early-returns `"None"` for `None`.
Example:
let ts: Option<Duration> = None;
assert_eq!(ts.display_unix_timestamp().to_string(), "None");
let ts = Some(Duration::from_millis(1723102819023));
assert_eq!(ts.display_unix_timestamp_short().to_string(), "2024-08-08T07:40:19.023");
xp-trumpet
reviewed
Feb 17, 2026
xp-trumpet
left a comment
xp-trumpet
left a comment
There was a problem hiding this comment.
@xp-trumpet reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on drmingdrmer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
feat: impl
DisplayUnixTimeStampExtforOption<Duration>Timestamps are often optional (e.g., "last seen at"), so accepting
Option<Duration>directly avoids callers needing to unwrap beforeformatting.
Nonerenders as the literal string"None", matching theconvention used by
DisplayOption.Internally,
DisplayUnixTimeStamp::durationis nowOption<Duration>;the
Displayimpl early-returns"None"forNone.Example:
chore: Bump ver: 0.2.5