Skip to content

Chore: Replace Vote<C> with VoteOf<C> #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Jan 3, 2025

Changelog

Chore: Replace Vote<C> with VoteOf<C>

Introduce the type alias VoteOf<C> to simplify future migration from the
fixed type Vote<C> to an associated type C::Vote.

By defining VoteOf<C> = Vote<C> now,
and later updating it to VoteOf<C> = C::Vote,
the migration can be handled with minimal code changes, avoiding
large-scale modifications in the future.


This change is Reviewable

Introduce the type alias `VoteOf<C>` to simplify future migration from the
fixed type `Vote<C>` to an associated type `C::Vote`.

By defining `VoteOf<C> = Vote<C>` now,
and later updating it to `VoteOf<C> = C::Vote`,
the migration can be handled with minimal code changes, avoiding
large-scale modifications in the future.
@drmingdrmer drmingdrmer merged commit f8dd4d5 into databendlabs:main Jan 3, 2025
33 of 34 checks passed
@drmingdrmer drmingdrmer deleted the 180-vote-of branch January 3, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant