Skip to content

Add settings dialog, CI status improvements, and draft PR support #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
everpcpc merged 7 commits into from
Jan 19, 2026
Merged

Add settings dialog, CI status improvements, and draft PR support #69

everpcpc merged 7 commits into from
Jan 19, 2026

Conversation

@everpcpc
Copy link
Member

@everpcpc everpcpc commented Jan 19, 2026 •
edited
Loading

Summary

This PR adds several UI improvements including a comprehensive settings dialog, enhanced CI status display with grouping and collapsing, and full support for draft PR workflows.

Key Features:

Settings Dialog

  • Theme selection (system/light/dark)
  • Font size adjustment (10-20px with validation)
  • AI provider toggles (Claude/Codex)
  • Terminal settings (shell and font size configuration)
  • Persistent storage with instant preview

CI Status Enhancements

  • Group CI checks by workflow name
  • Sort checks by status (failed → pending → success)
  • Collapsible success section to reduce visual clutter
  • Replace Unicode chevrons with standard Lucide icons
  • Show workflow names in the UI

Draft PR Support

  • Detect and display draft status with gray icons
  • Show draft label in both right panel and sidebar
  • Add "Mark as Ready for Review" button when:
    • PR is in draft state
    • PR is synced (no local commits to push)
    • All CI checks pass
  • Button works correctly in fork workflows by using same repo selection logic as pr view
  • Consolidate merged/isDraft boolean fields into single state enum (draft/open/merged)

Tests

  • Unit Test - All existing tests updated and passing
  • Logic Test - Tested settings persistence, CI status grouping, and draft PR workflows
  • Benchmark Test
  • No Test - Manual UI testing for visual components

Type of change

  • Bug Fix (non-breaking change which fixes an issue) - Fixed mark-pr-ready button functionality
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring - Consolidated PR state fields
  • Performance Improvement
  • Other (please describe):

@everpcpc everpcpc marked this pull request as ready for review January 19, 2026 07:31
@everpcpc everpcpc changed the title Add settings dialog with theme, font size, AI provider toggles, and terminal settings Add settings dialog and improve CI status display Jan 19, 2026
@everpcpc everpcpc marked this pull request as draft January 19, 2026 11:07
@everpcpc
Update CI status tests for grouped and collapsible display
be162f8
@everpcpc
Replace Unicode chevron with standard ChevronDown/ChevronRight icons …
7cfae76 
…in CI status badge
@everpcpc
Add draft PR status display and mark-as-ready functionality
1195afd 
- Add draft PR detection with gray icon styling in right panel and sidebar
- Consolidate merged/isDraft booleans into single state field (draft/open/merged)
- Add mark-as-ready button when draft PR has passing CI and is synced
- Update all UI components to use new state field
- Update tests to reflect new PR state structure
@everpcpc everpcpc changed the title Add settings dialog and improve CI status display Add settings dialog, CI status improvements, and draft PR support Jan 19, 2026
@everpcpc everpcpc marked this pull request as ready for review January 19, 2026 12:19
@everpcpc
Fix mark-pr-ready functionality and repo selection logic
a7e129e 
- Add markPRReady method to preload.ts to expose IPC handler to frontend
- Update mark-pr-ready to use same repo selection logic as pr view
- Try upstream and origin remotes in order, using first successful match
- Handle fork workflow with correct branch argument format
- Remove working tree clean requirement from mark-as-ready button
- Add detailed logging for debugging mark-pr-ready flow
@everpcpc everpcpc merged commit 9ccdd03 into databendlabs:main Jan 19, 2026
3 checks passed
@everpcpc everpcpc deleted the melbourne-wbt9c9em branch January 19, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@everpcpc