Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential solution for skipping sort #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

donaldcampbelljr
Copy link
Member

@ClaudeHu try this branch and see if it:
a. shortens time significantly,
b. provides the same answer for your presorted bed files

The original C++ implementation of uniwig does sort the starts and ends in memory regardless of the sort flag being set.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Project coverage is 61.20%. Comparing base (df443c2) to head (05dc754).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gtars/src/uniwig/cli.rs 0.00% 7 Missing ⚠️
gtars/src/uniwig/mod.rs 33.33% 4 Missing ⚠️
gtars/src/uniwig/utils.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   61.27%   61.20%   -0.08%     
==========================================
  Files          37       37              
  Lines        6102     6119      +17     
==========================================
+ Hits         3739     3745       +6     
- Misses       2363     2374      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant