Fixed Trailing Slashes in cp command + added unit tests #3921
+82
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Contributor
Author
|
Hey @shreyas-goenka Can you review this pr |
Contributor
|
Hi @varundeepsaini ! Thanks for the PR! Contributing to CLI requires a signed CLA If that's something you're willing to do, please reach out with a request to sign the CLA to dabs-feedback@databricks.com, and we will take it from there. Thank you! |
Contributor
Author
|
Hey @andrewnester Have sent the email |
andrewnester
requested changes
Nov 17, 2025
Contributor
Author
|
@andrewnester |
andrewnester
approved these changes
Nov 20, 2025
Contributor
Author
|
@andrewnester any idea why the integration tests havent run yet ? |
Contributor
|
@varundeepsaini I manually triggered integration tests, they should run now |
Collaborator
|
Commit: b25ff1c
27 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
auto-merge was automatically disabled
November 20, 2025 15:30
Head branch was pushed to by a user without write access
Contributor
Author
|
@andrewnester |
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
@andrewnester could you queue the integration tests |
Collaborator
|
Commit: 134c1a8
15 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
fjakobs
pushed a commit
that referenced
this pull request
Nov 21, 2025
Fixes: #2835 ## Changes Fixed handling of trailing directory separators in the `cp` command. When a target path ends with `/` or `\`, the command now validates that the directory exists before copying. If the directory doesn't exist, it returns a clear error message instead of failing later. Added a helper function `hasTrailingDirSeparator` to detect trailing directory separators for both Unix-style (`/`) and Windows-style (`\`) paths. ## Why Previously, the `cp` command didn't properly handle trailing directory separators. When users specified a target path like `target/dir/` (expecting it to be treated as a directory), the command would not validate that the directory exists first, leading to confusing error messages later in the copy process. This change ensures that trailing directory separators are explicitly treated as indicating a directory target, and validates that the directory exists upfront. ## Tests Added unit tests in `integration/cmd/fs/cp_test.go`: - `TestFsCpFileToNonExistentDir`: Tests copying files to both existing and non-existent directories with trailing slashes - `TestFsCpFileToNonExistentDirWindowsPaths`: Windows-specific tests for trailing backslashes (`\`) and forward slashes (`/`) on Windows The tests verify that: - Copying to an existing directory with a trailing separator succeeds - Copying to a non-existent directory with a trailing separator returns an appropriate error message - Both Unix-style (`/`) and Windows-style (`\`) separators are handled correctly --------- Co-authored-by: Andrew Nester <andrew.nester.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2835
Changes
Fixed handling of trailing directory separators in the
cpcommand. When a target path ends with/or\, the command now validates that the directory exists before copying. If the directory doesn't exist, it returns a clear error message instead of failing later.Added a helper function
hasTrailingDirSeparatorto detect trailing directory separators for both Unix-style (/) and Windows-style (\) paths.Why
Previously, the
cpcommand didn't properly handle trailing directory separators. When users specified a target path liketarget/dir/(expecting it to be treated as a directory), the command would not validate that the directory exists first, leading to confusing error messages later in the copy process. This change ensures that trailing directory separators are explicitly treated as indicating a directory target, and validates that the directory exists upfront.Tests
Added unit tests in
integration/cmd/fs/cp_test.go:TestFsCpFileToNonExistentDir: Tests copying files to both existing and non-existent directories with trailing slashesTestFsCpFileToNonExistentDirWindowsPaths: Windows-specific tests for trailing backslashes (\) and forward slashes (/) on WindowsThe tests verify that:
/) and Windows-style (\) separators are handled correctly