Implement Dagger Sandbox for the MCP #3940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjakobs
requested review from
a team,
andrewnester,
anton-107,
denik,
lennartkats-db,
pietern and
shreyas-goenka
as code owners
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This reverts commit 1e9ee36.
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
9 failing tests:
Top 25 slowest tests (at least 2 minutes):
|
keugenek
approved these changes
Nov 19, 2025
| databricks experimental apps-mcp --warehouse-id abc123 --docker-image node:20-alpine | ||
| # Start without containerized validation | ||
| databricks experimental apps-mcp --warehouse-id abc123 --use-dagger=false`, |
Contributor
There was a problem hiding this comment.
should this the default mode?
| log.Info(ctx, "Checking MCP server environment") | ||
|
|
||
| // Check Databricks authentication | ||
| w := cmdctx.WorkspaceClient(ctx) |
Contributor
There was a problem hiding this comment.
SDK template requires much more env vars in .env file - does it make sense to detect if there is SDK template installed and enforce checks for .env?
Contributor
Author
|
Closing for now. Might come back in a different shape later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1e9ee36.
Changes
Add a docker-based sandbox using dagger. Dagger is off be default and must be enabled explicitly by the user.
The dagger 3p lib is adding ~3MB to the CLI binary size.
Why
Tests