Skip to content

Conversation

@kanterov
Copy link
Collaborator

Changes

Fix formatting in the default template. Previously, there was a diff:

--- test_20251119/src/test_20251119/main.py
+++ test_20251119/src/test_20251119/main.py
@@ -5,7 +5,9 @@

 def main():
     # Process command-line arguments
-    parser = argparse.ArgumentParser(description="Databricks job with catalog and schema parameters")
+    parser = argparse.ArgumentParser(
+        description="Databricks job with catalog and schema parameters"
+    )
     parser.add_argument("--catalog", required=True)
     parser.add_argument("--schema", required=True)
     args = parser.parse_args()

The problem is in the default template and not specific to PyDABs.

Why

The template should be pre-formatted so that after the project is initialized, it's already in its final state.

Tests

Updated acceptance tests to check formatting for all files that template produces

Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Btw, pyproject.toml includes a line length for black but not for ruff.

Copy link
Contributor

@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is in sync with the 120 line length used elsewhere? And we need CI checks for this. I pinged you about this offline.

@kanterov
Copy link
Collaborator Author

@lennartkats-db does the change make sense? we can decide if we want to change formatter settings in pyproject.toml separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants