Fix a potential panic during databricks labs install --offline=true
#3955
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce tests for the offline-mode code paths.
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
pietern
approved these changes
Nov 20, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Looks good, thanks.
I'll merge when the unit tests come back green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a panic during
databricks labs install --offline=trueif the release cache can't be loaded. (Preliminary support for offline installs was introduced by #2049.)Why
This is easy to hit during offline installation if the archive hasn't been unpacked into the location expected by the code. When this happens the code should not panic but rather propagate the error.
Tests
Tested manually, and via some additional tests that cover loading the release cache in offline mode: