Add lazy warehouse resolution with smart discovery #3973
+104
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjakobs
requested review from
a team,
lennartkats-db and
pietern
as code owners
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: b31acf9
11 failing tests:
Top 9 slowest tests (at least 2 minutes):
|
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
force-pushed
the
mcp/lazy-auth
branch
from
4b6ea60 to
537c596
Compare
Implements intelligent warehouse auto-discovery: - Add GetWarehouseID() with smart fallback chain: 1. Check DATABRICKS_WAREHOUSE_ID environment variable 2. Query available warehouses via API 3. Prefer RUNNING warehouses 4. Fall back to STOPPED warehouses (auto-start) 5. Use first available warehouse - Cache warehouse ID in session after first resolution - Remove warehouse ID from CLI flags and config - Update NewDatabricksRestClient and ResourcesFromEnv to use GetWarehouseID Eliminates need to specify warehouse ID upfront.
fjakobs
force-pushed
the
mcp/lazy-warehouse-resolution
branch
from
a20f35d to
ced4c41
Compare
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
force-pushed
the
mcp/lazy-warehouse-resolution
branch
from
f5c131f to
ced4c41
Compare
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
arsenyinfo
reviewed
Nov 21, 2025
| } | ||
| } | ||
|
|
||
| // Return first available warehouse regardless of state |
There was a problem hiding this comment.
should we cover STOPPED + STOPPING together with the same priority and raise err here already? From what I read, the left states are DELETING / DELETED, not a good choice.
Contributor
Author
There was a problem hiding this comment.
I've improve the lookup code. I also consider starting and stopping now and ignore the deleting and deleted states.
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
force-pushed
the
mcp/lazy-warehouse-resolution
branch
from
70756b8 to
b31acf9
Compare
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
arsenyinfo
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements intelligent warehouse auto-discovery removing need for configuration.
Changes
Dependencies
Testing