Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML-30728] Added CLI support for Delta Sharing Models #662

Closed
wants to merge 4 commits into from
Closed

[ML-30728] Added CLI support for Delta Sharing Models #662

wants to merge 4 commits into from

Conversation

jinzhang21
Copy link

No description provided.

Jin Zhang added 3 commits July 19, 2023 11:10
Signed-off-by: Jin Zhang <jin.zhang@databricks.com>
Signed-off-by: Jin Zhang <jin.zhang@databricks.com>
Signed-off-by: Jin Zhang <jin.zhang@databricks.com>
@jinzhang21 jinzhang21 requested a review from andyl-db July 19, 2023 22:11
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 74.35% and project coverage change: -0.02% ⚠️

Comparison is base (9bb7f5b) 75.38% compared to head (f01d58d) 75.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   75.38%   75.36%   -0.02%     
==========================================
  Files          55       55              
  Lines        5122     5200      +78     
==========================================
+ Hits         3861     3919      +58     
- Misses       1261     1281      +20     
Files Changed Coverage Δ
databricks_cli/unity_catalog/delta_sharing_cli.py 80.57% <74.35%> (-1.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinzhang21 jinzhang21 requested a review from pietern July 20, 2023 20:08
databricks_cli/unity_catalog/delta_sharing_cli.py Outdated Show resolved Hide resolved
databricks_cli/unity_catalog/delta_sharing_cli.py Outdated Show resolved Hide resolved
databricks_cli/unity_catalog/delta_sharing_cli.py Outdated Show resolved Hide resolved
Signed-off-by: Jin Zhang <jin.zhang@databricks.com>
@jinzhang21 jinzhang21 requested a review from andyl-db July 20, 2023 21:23
Copy link
Contributor

@andyl-db andyl-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinzhang21 jinzhang21 closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants