Simplify SEA disposition: use connection parameters instead of statement type#1322
Open
gopalldb wants to merge 2 commits intodatabricks:mainfrom
Open
Simplify SEA disposition: use connection parameters instead of statement type#1322gopalldb wants to merge 2 commits intodatabricks:mainfrom
gopalldb wants to merge 2 commits intodatabricks:mainfrom
Conversation
The disposition (INLINE vs EXTERNAL_LINKS) was determined by statement type (QUERY/SQL/METADATA got cloud fetch, others got inline). This is wrong — disposition should be driven by connection parameters only: - shouldEnableArrow() — whether Arrow format is enabled - isCloudFetchEnabled() — whether cloud fetch (EnableQueryResultDownload) is enabled Removed the statementType-based branching in useCloudFetchForResult(). Now all statement types get the same disposition based on connection config, which is the correct behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Gopal Lal <gopal.lal@databricks.com>
- Test arrow+cloudFetch enabled: verifies disposition is not INLINE and format is ARROW_STREAM - Test cloudFetch disabled: verifies the condition resolves to INLINE (arrow enabled but cloud fetch disabled) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Gopal Lal <gopal.lal@databricks.com>
vikrantpuppala
approved these changes
Mar 26, 2026
sreekanth-db
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SEA result disposition (INLINE vs EXTERNAL_LINKS) was determined by statement type — only QUERY/SQL/METADATA got cloud fetch, while DML/DDL was forced to INLINE regardless of connection config. This is incorrect; disposition should be driven purely by connection parameters.
Changes
DatabricksSdkClient.useCloudFetchForResult(): RemovedStatementTypeparameter. Now based solely onshouldEnableArrow()&&isCloudFetchEnabled()(theEnableQueryResultDownloadconnection property).Before
After
Test plan
testDisposition_arrowAndCloudFetchEnabled_usesExternalLinks— verifies ARROW_STREAM format and non-INLINE disposition when both configs enabledtestDisposition_cloudFetchDisabled_usesInline— verifies INLINE disposition when cloud fetch is disabledNO_CHANGELOG=true
This pull request was AI-assisted by Isaac.