[Internal] GetRun logic paginates more arrays #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkiko10
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Comment on lines
+29
to
+32
| run.JobClusters = append(run.JobClusters, nextRun.JobClusters...) | ||
| run.JobParameters = append(run.JobParameters, nextRun.JobParameters...) | ||
| run.RepairHistory = append(run.RepairHistory, nextRun.RepairHistory...) | ||
| run.NextPageToken = nextRun.NextPageToken |
There was a problem hiding this comment.
Could you add a comment to explain why we are doing this?
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
gkiko10
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The existing code only paginates tasks and iterations. With this PR we update the logic to also paginate job_clusters, job_parameters and repair_history. This changes are needed for Jobs API 2.2 compatibility.
How is this tested?
I enabled API 2.2 calls by modifying URL string
/api/2.2/jobs/runs/getin service/jobs/impl.go. Then I ran unit test from service/jobs/ext_api_test.go