Add custom Duration and Timestamp classes with nanosecond support#975
Closed
hectorcast-db wants to merge 8 commits intomainfrom
Closed
Add custom Duration and Timestamp classes with nanosecond support#975hectorcast-db wants to merge 8 commits intomainfrom
hectorcast-db wants to merge 8 commits intomainfrom
Conversation
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
reviewed
May 21, 2025
Comment on lines
+28
to
+42
| def __init__(self, seconds: int = 0, nanoseconds: int = 0) -> None: | ||
| """Initialize a Duration with seconds and nanoseconds. | ||
|
|
||
| Args: | ||
| seconds: Number of seconds | ||
| nanoseconds: Number of nanoseconds (0-999999999) | ||
|
|
||
| Raises: | ||
| TypeError: If seconds or nanoseconds are not integers | ||
| ValueError: If nanoseconds is not between 0 and 999999999 | ||
| """ | ||
| if not isinstance(seconds, int): | ||
| raise TypeError("seconds must be an integer") | ||
| if not isinstance(nanoseconds, int): | ||
| raise TypeError("nanoseconds must be an integer") |
Contributor
There was a problem hiding this comment.
Why do we need this type check when we explicitly stated that in the function arguments?
Contributor
Author
There was a problem hiding this comment.
The type in the arguments are only "hints" for the linter, but python does not enforce them.
| self.nanoseconds = nanoseconds | ||
|
|
||
| @classmethod | ||
| def from_timedelta(cls, td: timedelta) -> "Duration": |
Contributor
There was a problem hiding this comment.
This is returning "Duration" with quotes. Is this expected?
Contributor
Author
There was a problem hiding this comment.
Yes. In Python you cannot use a type before introduced. This is a workaround introduced at some point:
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
approved these changes
May 22, 2025
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
databricks/sdk/common.py
Outdated
| from datetime import datetime, timedelta, timezone | ||
| from decimal import Decimal | ||
|
|
||
| _LOG = logging.getLogger("databricks.sdk") |
Comment on lines
+1
to
+4
| """Common types for the Databricks SDK. | ||
|
|
||
| This module provides common types used by different APIs. | ||
| """ |
Contributor
There was a problem hiding this comment.
Could we actually move this in databricks/sdk/core/common? I'd like to reserve databricks/sdk/common for SDK-Mod.
Contributor
Author
There was a problem hiding this comment.
moved to databricks/sdk/common_types/common.py since moving it to core creates circular dependencies witth the core.py file.
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
force-pushed
the
hectorcast-db/duration-timestamp
branch
from
e9c4694 to
389e0c6
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
renaudhartert-db
requested changes
Sep 17, 2025
Contributor
renaudhartert-db
left a comment
renaudhartert-db
left a comment
There was a problem hiding this comment.
This is not relevant anymore right?
Contributor
Author
|
Not relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Add custom Duration and Timestamp classes with nanosecond support and helper methods
How is this tested?
Added tests
NO_CHANGELOG=true