Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update genai_cookbook site content with new agent sample app #32

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

prithvikannan
Copy link
Collaborator

@prithvikannan prithvikannan commented Oct 1, 2024

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

  • Update references in the site markdown to new /agent_app_sample_code at tag v0.2.0
  • Rename references to RAG to Agent
  • Update iterate eval pages since we no longer publish a B_quality_iteration folder to handhold iteration
  • Misc edits

How is this PR tested?

Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
@prithvikannan prithvikannan changed the title Update genai_cookbook site content with new aget sample app Update genai_cookbook site content with new agent sample app Oct 1, 2024
Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this up since the new agent code does not provide a B_quality_iteration/ folder. instead we just advise users to edit their earlier notebooks and use mlflow to compare

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this up since the new agent code does not provide a B_quality_iteration/ folder. instead we just advise users to edit their earlier notebooks and use mlflow to compare

@@ -24,9 +24,8 @@ You can find all of the sample code referenced throughout this section [here](ht
3. Unity Catalog Schema where the output Delta Tables with the parsed/chunked documents and Vector Search indexes are stored, either:
- Write access to an existing [Unity Catalog](https://docs.databricks.com/en/data-governance/unity-catalog/index.html) and [Schema](https://docs.databricks.com/en/data-governance/unity-catalog/index.html#the-unity-catalog-object-model)
- Permissions to create a new Unity Catalog and Schema - the setup Notebook will do this for you
4. A [**single-user**](https://docs.databricks.com/en/compute/configure.html#access-modes) cluster running [DBR 14.3+](https://docs.databricks.com/en/release-notes/runtime/index.html) with access to the internet
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serverless works now

Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
Copy link
Contributor

@aravind-segu aravind-segu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit.

genai_cookbook/nbs/5-hands-on-build-poc.md Outdated Show resolved Hide resolved
@@ -66,19 +66,17 @@ As a reminder, there are 3 types of potential fixes:
-->

#### Instructions
For all types, you will use the [`B_quality_iteration/02_evaluate_fixes`](https://github.com/databricks/genai-cookbook/blob/main/rag_app_sample_code/B_quality_iteration/02_evaluate_fixes.py) Notebook to evaluate the resulting chain versus your baseline configuration (at first, this is your POC) and pick a "winner". This notebook will help you pick the winning experiment and deploy it to the Review App or a production-ready, scalable REST API.
Based on which type of fix you want to make, modify the [`00_global_config`](https://github.com/databricks/genai-cookbook/blob/v0.2.0/agent_app_sample_code/00_global_config.py), [`02_data_pipeline`](https://github.com/databricks/genai-cookbook/blob/v0.2.0/agent_app_sample_code/02_data_pipeline.py), or the [`03_agent_proof_of_concept`](https://github.com/databricks/genai-cookbook/blob/v0.2.0/agent_app_sample_code/03_agent_proof_of_concept.py). Use the [`05_evaluate_poc_quality`](https://github.com/databricks/genai-cookbook/blob/v0.2.0/agent_app_sample_code/05_evaluate_poc_quality.py) notebook to evaluate the resulting chain versus your baseline configuration (at first, this is your POC) and pick a "winner". This notebook will help you pick the winning experiment and deploy it to the Review App or a production-ready, scalable REST API.

1. Open the [`B_quality_iteration/02_evaluate_fixes`](https://github.com/databricks/genai-cookbook/blob/main/rag_app_sample_code/B_quality_iteration/02_evaluate_fixes.py) Notebook
Copy link
Contributor

@aravind-segu aravind-segu Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should in theory, but we felt that it was too heavy-weight for this cookbook. we are planning to drop the whole /rag_app_sample_code folder.

Signed-off-by: Prithvi Kannan <prithvi.kannan@databricks.com>
@prithvikannan prithvikannan merged commit 4669f46 into databricks:main Oct 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants