Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed query blocking #69

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Fix failed query blocking #69

merged 2 commits into from
Aug 8, 2024

Conversation

hczhu-db
Copy link
Collaborator

@hczhu-db hczhu-db commented Aug 7, 2024

Shouldn't call parseRequestQueryString() before processing the query.

Tested on a dev region


$ k-m3 dev-azure-westus port-forward query-frontend-read-regional-deployment-7fc87cd49d-2wc95 7201

$ curl 'http://localhost:7201/api/v1/query' -X POST -F 'query=count(up)'
{"status":"success","data":{"resultType":"vector","result":[{"metric":{},"value":[1723075712.91,"2708"]}]}}

Copy link
Collaborator

@jnyi jnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix

@hczhu-db hczhu-db merged commit 936f992 into db_main Aug 8, 2024
11 of 12 checks passed
@jnyi jnyi deleted the fix-query-frontend branch November 1, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants