forked from thanos-io/thanos
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES-1214414] Thanos v0.36.0 upgrade #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow using different listing strategies Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Expose flags for block list strategy Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Run make docs Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Fix whitespace Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add CHANGELOG entry Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
* Receive: fix issue-7248 by introducing a worker pool Signed-off-by: Yi Jin <yi.jin@databricks.com> * fix unit test bug Signed-off-by: Yi Jin <yi.jin@databricks.com> * fix CLI flags not pass into the receive handler Signed-off-by: Yi Jin <yi.jin@databricks.com> * address comments Signed-off-by: Yi Jin <yi.jin@databricks.com> * init context in constructor Signed-off-by: Yi Jin <yi.jin@databricks.com> --------- Signed-off-by: Yi Jin <yi.jin@databricks.com>
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
This commit adds a resource_attributes field to the OTLP tracing configuration. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Adding a minimal test case for issue thanos-io#6775 - reproduces the panic in the compactor. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
This commit adds a new tracing span for remotely delegated queries with attributes related to the query and remote engine. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
* Adding repro case for broken query with distributed engine Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Fixing problem with distributed queries and xfunctios Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Adding support for extended functions in tenancy enforcement Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Moving custom parser to new package Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * fixing go-lint Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Using same opts and reorganize imports Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * fixing problem with query format Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * fixing flaky tests Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * removing extra test Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * yet another flaky test Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> --------- Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
* rule Signed-off-by: Vanshikav123 <vanshikav928@gmail.com> * rule-changes Signed-off-by: Vanshikav123 <vanshikav928@gmail.com> * prettier Signed-off-by: Vanshikav123 <vanshikav928@gmail.com> * Rebuild Signed-off-by: Vanshikav123 <vanshikav928@gmail.com> * changes after make react-app Signed-off-by: Vanshikav123 <vanshikav928@gmail.com> --------- Signed-off-by: Vanshikav123 <vanshikav928@gmail.com>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
When using the exemplars proxy to search for exemplars on receivers, if one receiver had tenants that did not match the selector on the external label it would get skipped completely even if it had a tenant that actually matched Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com>
* Update minio-go to v7.0.70 Add support for EKS Pod Identity fix issue: thanos-io#7157 Signed-off-by: farhad <eqfarhad@gmail.com> * Changelog - support for EKS Pod Identity Updated changelog Signed-off-by: farhad <eqfarhad@gmail.com> --------- Signed-off-by: farhad <eqfarhad@gmail.com>
thanos-io#7338) * fixing extended functions support in more places Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Adding new failint for the Parse() method Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Adding new method for ParseMetricSelector Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Fixing missing imports Extending test to check behavior More missing imports Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Fixing method name Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Solving references to forbidden functions Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> * Treating promql validation from ParseExpr Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> * fixing funcs Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com> --------- Signed-off-by: Pedro Tanaka <pedro.stanaka@gmail.com> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.70.0 to 5.91.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.70.0...v5.91.0) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
* Align tenant pruning according to wall clock. Pruning a tenant currently acquires a lock on the tenant's TSDB, which blocks reads from incoming queries. We have noticed spikes in query latency when tenants get decomissioned since each receiver will prune the tenant at a different time. To reduce the window where queries get degraded, this commit makes sure that pruning happens at predictable intervals by aligning it to the wall clock, similar to how head compaction is aligned. The commit also changes the tenant deletion condition to look at the duration from the min time of the tenant, rather than from the last append time. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Improve tests Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9. - [Commits](indutny/node-ip@v1.1.5...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…hanos-io#7348) Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.1 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.1...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Propagate request ID through gRPC context The request ID only gets propagated through HTTP calls and is not available in gRPC servers. This commit adds intereceptors to grpc servers and clients to make sure request ID propagation happens. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add license Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
* compact/planner: fix issue 6775 It doesn't make sense to vertically compact downsampled blocks so mark them with the no compact marker if downsampled blocks were detected in the plan. Seems like the Planner is the best place for this logic - I just repeated the previous pattern with the large index file filter. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * CHANGELOG: add item Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> --------- Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Signed-off-by: Markus Meyer <m.meyer@mytaxi.com>
Signed-off-by: Markus Meyer <m.meyer@mytaxi.com>
Signed-off-by: Markus Meyer <m.meyer@mytaxi.com>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps google.golang.org/protobuf from 1.34.1 to 1.34.2. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
* *: fix server grpc histograms (thanos-io#7493) Signed-off-by: Michael Hoffmann <mhoffm@posteo.de> * Close endpoints after the gRPC server has terminated (thanos-io#7509) Endpoints are currently closed as soon as we receive a SIGTERM or SIGINT. This causes in-flight queries to get cancelled since outgoing connections get closed instantly. This commit moves the endpoints.Close call after the grpc server shutdown to make sure connections are available as long as the server is running. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Cut release candidate v0.36.0-rc.1 Signed-off-by: Michael Hoffmann <mhoffm@posteo.de> --------- Signed-off-by: Michael Hoffmann <mhoffm@posteo.de> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>
* Proxy: Query goroutine leak when `store.response-timeout` is set (thanos-io#7618) time.AfterFunc() returns a time.Timer object whose C field is nil, accroding to the documentation. A goroutine blocks forever on reading from a `nil` channel, leading to a goroutine leak on random slow queries. Signed-off-by: Mikhail Nozdrachev <mikhail.nozdrachev@aiven.io> * pkg/clientconfig: fix TLS configs with only CA (thanos-io#7634) 065e3dd introduced a regression: TLS configurations for Thanos Ruler query and alerting with only a CA file failed to load. For instance, the following snippet is a valid query configuration: ``` - static_configs: - prometheus.example.com:9090 scheme: https http_config: tls_config: ca_file: /etc/ssl/cert.pem ``` The test fixtures (CA, certificate and key files) are copied from prometheus/common and are valid until 2072. Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Cut patch release v0.36.1 Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix failing e2e test (thanos-io#7620) Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> --------- Signed-off-by: Mikhail Nozdrachev <mikhail.nozdrachev@aiven.io> Signed-off-by: Simon Pasquier <spasquie@redhat.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: 🌲 Harry 🌊 John 🏔 <johrry@amazon.com> Co-authored-by: Mikhail Nozdrachev <mikhail.nozdrachev@aiven.io> Co-authored-by: Simon Pasquier <spasquie@redhat.com> Co-authored-by: Harry John <johrry@amazon.com>
jnyi
reviewed
Aug 22, 2024
hczhu-db
added
documentation
Improvements or additions to documentation
and removed
documentation
Improvements or additions to documentation
labels
Aug 23, 2024
hczhu-db
requested review from
a team,
christopherzli,
jnyi and
yuchen-db
and removed request for
a team
August 23, 2024 17:22
jnyi
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for making this version upgrade
yuchen-db
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing in https://github.com/databricks/universe/pull/693757