Update thanos objstore library to pull object duration metric fix #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulong-db
force-pushed
the
yulong-db/fix-objstore-metrics
branch
from
0afa397
to
ef4fb20
Compare
yulong-db
force-pushed
the
yulong-db/fix-objstore-metrics
branch
from
ef4fb20
to
84da98c
Compare
yulong-db
changed the title
yulong-db
requested review from
a team,
christopherzli,
jnyi,
hczhu-db and
yuchen-db
and removed request for
a team
jnyi
approved these changes
Nov 13, 2024
|
jenkins merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes.
Pull in this fix to fix the wrong metrics instrumented from objstore.
Also fixed API breakage due to this version bump.
Verification
Deployed to integration test cluster.
Before the fix, the all reported number are in nanosecond quantity but reported as seconds (A difference of 10^9 multiplier) so many of them fall into the
+infbucket.Now, after this fix, the GET duration is much more reasonable. Most are fall into the
0.01or0.1bucket.Deployed to dev-azure-koreacentral too, is able to run.
