Added Collection functionality to run cli cmd as collection #113
Conversation
|
✅ 12/12 passed, 2 skipped, 22s total Running from acceptance #148 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 79.00% 79.65% +0.64%
==========================================
Files 14 14
Lines 1515 1524 +9
Branches 274 277 +3
==========================================
+ Hits 1197 1214 +17
+ Misses 230 224 -6
+ Partials 88 86 -2 ☔ View full report in Codecov by Sentry. |
| @@ -30,6 +31,15 @@ def needs_workspace_client(self): | |||
| return False | |||
| return True | |||
|
|
|||
| def run_as_collection(self) -> bool: | |||
There was a problem hiding this comment.
could you add a comment explaining how this would work, i.e. the command should have is_collection annotation & collection_workspace_id is not null
There was a problem hiding this comment.
also, our function would always receive collection_workspace_id, the difference is that it might be null instead of an integer right?
There was a problem hiding this comment.
This is my understanding. We mark a method as collection eligible by setting is_collection as True.
Now there are two ways to execute it , if the collection_workspace_id is passed, then create account context and iterate through all workspace context of the collection and run the associated command once for each workspace if collection_workspace_id is not passed, then run it as current installation cmd.
| return False | ||
| sig = inspect.signature(self.fn) | ||
| for param in sig.parameters.values(): | ||
| if param.name == "collection_workspace_id": |
There was a problem hiding this comment.
Can we implement this on UCX only, for now?
This change introduces the concept of collection in cli commands.
Background:
A cli cmd can be run as a current workspace installation command or as a collection.
When it is run as a collection, an Account client is created which can be used to run the cmd for all workspaces of a collection
When it is run as a non collection, a workspace client is created
Changes: