Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let make coverage open coverage report when coverage threshold is not met #2742

Closed
wants to merge 2 commits into from
Closed

Let make coverage open coverage report when coverage threshold is not met #2742

wants to merge 2 commits into from

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented Sep 25, 2024 •
edited
Loading

Changes

Let make coverage open coverage report when coverage threshold is not met

Tests

  • manually tested

@JCZuurmond JCZuurmond added the internal this pull request won't appear in release notes label Sep 25, 2024
@JCZuurmond JCZuurmond self-assigned this Sep 25, 2024
@JCZuurmond JCZuurmond changed the title Fix coverage Let make coverage open coverage report when coverage threshold is not madea Sep 25, 2024
@JCZuurmond JCZuurmond changed the title Let make coverage open coverage report when coverage threshold is not madea Let make coverage open coverage report when coverage threshold is not met Sep 25, 2024
@JCZuurmond JCZuurmond marked this pull request as ready for review September 25, 2024 07:34
@JCZuurmond JCZuurmond requested a review from a team as a code owner September 25, 2024 07:34
@github-actions GitHub Actions
Copy link

✅ 2/2 passed, 23s total

Running from acceptance #6123

@JCZuurmond
Copy link
Member Author

JCZuurmond commented Sep 25, 2024 •
edited
Loading

Note the different coverage percentages

  • In CI with Python 3.10.15: 90.02%
  • In CI with Python 3.12.6: 90.25%
  • In CI with Python 3.11.10: 90.60%
  • Locally with Python 3.10.13: 89.77%
  • Locally with Python 3.10.15: 89.78% -> How is this possible?

@JCZuurmond
Copy link
Member Author

@nfx : Coverage report is broken: https://app.codecov.io/github/databrickslabs/ucx/commit/464c7d1aaabf382e2049a2e786e3da3da7ea2dfb

asnare
asnare approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@asnare asnare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JCZuurmond
Copy link
Member Author

Covered by #2694

@JCZuurmond JCZuurmond closed this Sep 25, 2024
@JCZuurmond JCZuurmond deleted the fix/coverage branch October 16, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnare asnare asnare approved these changes

Assignees

@JCZuurmond JCZuurmond

Labels
internal this pull request won't appear in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JCZuurmond @asnare