Fixed api compatibility with DBR16 #4712
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FastLee
had a problem deploying
to
account-admin
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4712 +/- ##
==========================================
- Coverage 87.95% 87.95% -0.01%
==========================================
Files 123 123
Lines 17570 17569 -1
Branches 3714 3713 -1
==========================================
- Hits 15453 15452 -1
Misses 1425 1425
Partials 692 692 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 55/55 passed, 5 skipped, 2h44m24s total Running from acceptance #8952 |
FastLee
had a problem deploying
to
account-admin
GitHub Actions
Error
FastLee
temporarily deployed
to
account-admin
GitHub Actions
Inactive
pritishpai
reviewed
Nov 12, 2025
| """Converts a Hive metastore table to external using Spark JVM methods.""" | ||
| logger.info(f"Changing HMS managed table {src_table.name} to External Table type.") | ||
| inventory_table = self._tables_crawler.full_name | ||
| database = self._spark._jvm.scala.Some(src_table.database) # pylint: disable=protected-access |
Contributor
There was a problem hiding this comment.
This can be retained under the try right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4331