Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lubridate from list of packages to install during setup #894

Closed
tobyhodges opened this issue Jul 10, 2024 · 3 comments
Closed

Remove lubridate from list of packages to install during setup #894

tobyhodges opened this issue Jul 10, 2024 · 3 comments
Assignees
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors

Comments

@tobyhodges
Copy link
Member

As pointed out my @mikemahoney218 in #879, lubridate is now part of the combined tidyverse package. In the lesson setup instructions, we state that it should be installed alongside tidyverse:

install.packages(c("tidyverse", "lubridate", "ratdat"))

Although I doubt the redundancy is doing much harm, it seems that this can be simplified to include only tidyverse and ratdat

@tobyhodges tobyhodges added help wanted Looking for Contributors good first issue Good issue for first-time contributors labels Jul 10, 2024
@doujouDC
Copy link
Contributor

@tobyhodges I will work on this on Friday

@doujouDC
Copy link
Contributor

@tobyhodges would you recommend that I simply remove lubridate or provide some context about this now being part of the tidyverse. Wickham mentions this "Lubridate is part of core tidyverse, but it also exists as a standalone package" in R4DS

@tobyhodges
Copy link
Member Author

I think it can be safely removed altogether. The primary audience for the setup instructions is novice learners who just want to get everything ready for a workshop, and who may not have a mental model yet for packages, the tidyverse etc. As such, Beyond the fundamental steps that should be taken to prepare for the workshop, any discussion would be unnecessary IMO, perhaps even counterproductive.

@doujouDC doujouDC self-assigned this Sep 24, 2024
doujouDC added a commit that referenced this issue Sep 24, 2024
Updated to reflect changes suggested in #894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors
Projects
None yet
Development

No branches or pull requests

2 participants