Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mentions of lubridate from setup instructions #906

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

doujouDC
Copy link
Contributor

Updated to reflect changes suggested in #894

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

Updated to reflect changes suggested in #894
Copy link

github-actions bot commented Sep 24, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/R-ecology-lesson/compare/md-outputs..md-outputs-PR-906

The following changes were observed in the rendered markdown documents:

 config.yaml (new) |   81 +++
 md5sum.txt        |    2 +-
 renv.lock (new)   | 1569 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 setup.md          |    5 +-
 4 files changed, 1653 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-24 05:30:49 +0000

@doujouDC
Copy link
Contributor Author

Updated to address suggestions made in #894. @tobyhodges sorry to keep tagging you. Hopefully I did this correctly

@doujouDC doujouDC closed this Sep 24, 2024
@tobyhodges
Copy link
Member

The changes look good, thanks @doujouDC. However, I think you closed the pull request when you intended to merge it? I will reopen and review.

@tobyhodges tobyhodges reopened this Sep 24, 2024
@tobyhodges tobyhodges changed the title Update setup.md remove mentions of lubridate from setup instructions Sep 24, 2024
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @doujouDC! 🙌

github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
@doujouDC doujouDC merged commit 4e144b4 into main Sep 24, 2024
7 checks passed
@doujouDC doujouDC deleted the doujouDC-patch-1 branch September 24, 2024 10:53
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Auto-generated via {sandpaper}
Source  : 4e144b4
Branch  : main
Author  : Doug Joubert <doujouDC@users.noreply.github.com>
Time    : 2024-09-24 10:53:44 +0000
Message : Merge pull request #906 from datacarpentry/doujouDC-patch-1

remove mentions of lubridate from setup instructions
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Auto-generated via {sandpaper}
Source  : 50fee3a
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-09-24 10:55:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 4e144b4
Branch  : main
Author  : Doug Joubert <doujouDC@users.noreply.github.com>
Time    : 2024-09-24 10:53:44 +0000
Message : Merge pull request #906 from datacarpentry/doujouDC-patch-1

remove mentions of lubridate from setup instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants