Bump lcp to v0.2.10 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluele
reviewed
Oct 2, 2024
e2e/Enclave.mk
Outdated
| @@ -130,6 +129,6 @@ $(Signed_RustEnclave_Name): $(RustEnclave_Name) | |||
|
|
|||
| .PHONY: enclave | |||
| enclave: | |||
| @cd enclave && RUSTFLAGS=$(RUSTFLAGS) cargo build $(CARGO_TARGET) $(CARGO_FEATURES) | |||
| cd enclave && RUSTFLAGS=$(RUSTFLAGS) cargo build $(CARGO_TARGET) $(CARGO_FEATURES) | |||
There was a problem hiding this comment.
Sorry, it's my mistake. I'll revert it. 🙇🏼♂️
bluele
reviewed
Oct 2, 2024
e2e/Enclave.mk
Outdated
| @@ -52,7 +49,8 @@ endif | |||
|
|
|||
| SGX_COMMON_CFLAGS += -fstack-protector | |||
|
|
|||
| CARGO_FEATURES = --features=default | |||
| ENCLAVE_CARGO_FEATURES = --features=default | |||
| APP_CARGO_FEATURES = --features=default | |||
There was a problem hiding this comment.
Looks like APP_CARGO_FEATURES is unused and not necessary. I think these changes (*_CARGO_FEATURES) are unnecessary.
bluele
reviewed
Oct 2, 2024
| # cargo-machete found the following unused dependencies in this directory: | ||
| # light-client -- ./e2e/lcp/modules/light-client/Cargo.toml: | ||
| # serde | ||
| lcp/ |
There was a problem hiding this comment.
I didn't realize this. In cases where the ibc feature is not enabled, serde may not be necessary.
bluele
reviewed
Oct 2, 2024
| @@ -52,27 +49,20 @@ endif | |||
|
|
|||
| SGX_COMMON_CFLAGS += -fstack-protector | |||
|
|
|||
| CARGO_FEATURES = --features=default | |||
There was a problem hiding this comment.
@junichi-tanaka Can you also remove CARGO_FEATURES reference in enclave target?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What Changed