-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Schema 4.5 #166
Conversation
…ties for Schema 4.5
…affiliationIdentifier and nameIdentifier
…sCite; adjust publisher reads for bibtex and the Metadata model
FYI, I tested this branch of bolognese in the current main branch of lupo (prior to the 4.5 feature branch merge). All rspec tests passed, so bolognese should still be deployable in lupo if this branch is merged without any changes to lupo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there :)
Changes looks good to me 🎉 , I have suggested some minor refactoring changes.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks great to me. Thank you for the work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment to the last change @codycooperross made to the dc_json writer. Good catch, Cody.
Purpose
Implements the new Schema 4.5 features and XSD, in particular the expansion of the
publisher
property to allow for additional attributes.closes: datacite/lupo#1004 #165
Approach
Modifies readers and writers to support both
publisher
as a hash with new attributes (publisherIdentifier
,publisherIdentifierScheme
, etc.) andpublisher
as a string. Adds tests for reading and writing these attributes.This PR also fixes an issue described in #165 that resulted in errors when validating the new
datacite-example-full-v4.5.xml
example, which contains a geoLocationPolygon property.Open Questions and Pre-Merge TODOs
publisher
properties beyond DataCite XML. Mapping from and to other schemas will be part of future work.crossref_writer.rb
is currently unmodified. Based on this test, it seems like writing Crossref metadata is expected to produce anil
value:bolognese/spec/writers/crossref_writer_spec.rb
Lines 15 to 21 in 7b3e8cd
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: