Fixed the scope issue for the private method #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def abstract_description | ||
| # Fetch the first description with descriptionType "Abstract" | ||
| descriptions&.find { |d| d["descriptionType"] == "Abstract" } | ||
| end |
There was a problem hiding this comment.
i'm just wondering if we could perhaps DRY this implementation since we do repeat this method. I'm not sure about the code structure but maybe it could go into a writers concern or in some utility module? if this is not possible please do not hesitate to let me know.
There was a problem hiding this comment.
You are absolutely correct Wendel, I am just thinking what would be best place to add these to helper file. Thank you for the review
There was a problem hiding this comment.
@wendelfabianchinsamy moved the method to the common place.
There was a problem hiding this comment.
Brilliant! Nice one @ashwinisukale 🚀.
wendelfabianchinsamy
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes: #168
Approach
Upgrade bolognese gem version in Lupo from 1.11.0 to 1.11.2.
abstract_descriptionis a helper method created to show abstract description, this is not a field in database. When we upgraded there is update in zeitwerk gem from 2.6.1 to 2.6.8So the way class loads might have become strict, hence it was working before and now it's failing.
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: