Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for NoMethodError when reading blank publisher properties from DataCite XML #181

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

codycooperross
Copy link
Contributor

@codycooperross codycooperross commented Dec 7, 2023

Fixes #180

Purpose

Blank publisher properties were causing a NoMethodError when being read from DataCite XML.

closes: #180

Approach

Checks for a "__content__" value before stripping the value.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@codycooperross codycooperross merged commit b472e46 into master Dec 7, 2023
5 checks passed
@codycooperross codycooperross deleted the codycooperross/issue180 branch December 7, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError: undefined method `strip' for nil:NilClass
3 participants