Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ORCID and ROR identifiers ending with a / not being rendered in JSON when converting from XML #189

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

codycooperross
Copy link
Contributor

Purpose

Fix for ORCID and ROR identifiers ending with a / not being rendered in JSON when converting from XML.

closes: #188

Approach

Permits trailing slashes in validate_orcid and validate_ror methods.

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 merged commit 02e1860 into master Feb 26, 2024
5 checks passed
@svogt0511 svogt0511 deleted the codycooperross/issue188 branch February 26, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nameIdentifier ORCID identifiers ending with a / are not rendered in JSON when converting from XML
2 participants