Add constraint property graph mutation#488
Open
vish-cs wants to merge 1 commit intodatacommonsorg:masterfrom
Open
Add constraint property graph mutation#488vish-cs wants to merge 1 commit intodatacommonsorg:masterfrom
vish-cs wants to merge 1 commit intodatacommonsorg:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a mutation to generate constraintProperties for StatisticalVariable nodes and refactors several areas to handle node IDs for optimization purposes. The primary logic resides in McfMutator. My review has identified a critical issue in the constraintProperties generation that produces malformed DCIDs, along with several opportunities for improving code maintainability and performance. I've also included a comment regarding potential code duplication that would benefit from clarification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new MCF transformation to add constraint properties in McfMutator where we already do quantity range and lat-long transformations.
Updated various test files required due to the added logic