Skip to content

Spanner fixes#1642

Merged
n-h-diaz merged 1 commit intodatacommonsorg:masterfrom
n-h-diaz:u
Oct 21, 2025
Merged

Spanner fixes#1642
n-h-diaz merged 1 commit intodatacommonsorg:masterfrom
n-h-diaz:u

Conversation

@n-h-diaz
Copy link
Contributor

@n-h-diaz n-h-diaz commented Oct 21, 2025

Separating out some fixes from #1639 to unblock while the stale reads are still in discussion

(The failing tests were making it harder to evaluate performance, so it'd be helpful to get the fixes in sooner)

Includes

  • Sorting observation query test results for determinism in tests
  • Adding "distinct" to all chaining queries to avoid duplicates. "Match any" is not sufficient if there are multiple paths between nodes

@n-h-diaz n-h-diaz marked this pull request as ready for review October 21, 2025 17:04
@n-h-diaz n-h-diaz requested review from hqpho and keyurva and removed request for keyurva October 21, 2025 17:04
Copy link
Contributor

@keyurva keyurva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

WHERE
e.predicate = 'specializationOf']-{1,10}(n:Node)
RETURN
RETURN DISTINCT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how these sql goldens show the changes clearly.

WHERE
n.subject_id = value
RETURN
subject_id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: Consider making indentations of the returned fields consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks! (sorry I think it's showing up weird in github, but it should be consistent)

@n-h-diaz n-h-diaz added this pull request to the merge queue Oct 21, 2025
Merged via the queue into datacommonsorg:master with commit 4ddec3c Oct 21, 2025
4 checks passed
@n-h-diaz n-h-diaz deleted the u branch October 21, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants