Skip api key verification for nl /version endpoint#1780
Skip api key verification for nl /version endpoint#1780clincoln8 wants to merge 1 commit intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello @clincoln8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the accessibility of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly implements the logic to skip API key verification for the /version endpoint by adding a condition to the Apigee proxy configuration. However, the current implementation does not account for requests that include a trailing slash in the path (e.g., /version/). I've provided a suggestion to use a regular expression to make the path matching more robust and handle both cases.
Allow unauthenticated access to
Tested on nonprod:
This should not be deployed to apigee-prod until deployment freeze ends.