Update backup multi-domain cert references to reissued cert#1809
Update backup multi-domain cert references to reissued cert#1809juliawu merged 1 commit intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the references to a multi-domain certificate across various environment configurations. The change ensures that the systems correctly point to the newly reissued certificate, maintaining secure communication and preventing service disruptions that could arise from an expired or outdated certificate reference. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the multi-domain certificate reference from multi-domain-2025 to multi-domain-2026 across the autopush, prod, and staging environments. The changes are correct and align with the goal of updating the reissued certificate.
The suggestions to mark the hardcoded certificate names as technical debt and parameterize these values in the Helm chart are valid and will improve long-term maintainability and simplify future certificate rotations. The TODO comments will help track this for future improvement.
| annotations: | ||
| { | ||
| ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2025", | ||
| ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026", |
There was a problem hiding this comment.
To improve maintainability and reduce the risk of errors during future certificate rotations, it's best to avoid hardcoding the year-specific certificate name. A better approach would be to parameterize this value. Adding a TODO comment here, referencing the original issue, will help track this technical debt and guide future developers.
# TODO(b/492252963): Parameterize the certificate name to simplify future rotations.
ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026",| annotations: | ||
| { | ||
| ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2025,api-esp", | ||
| ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026,api-esp", |
There was a problem hiding this comment.
To improve maintainability and reduce the risk of errors during future certificate rotations, it's best to avoid hardcoding the year-specific certificate name. A better approach would be to parameterize this value. Adding a TODO comment here, referencing the original issue, will help track this technical debt and guide future developers.
# TODO(b/492252963): Parameterize the certificate name to simplify future rotations.
ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026,api-esp",| annotations: | ||
| { | ||
| ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2025,api-esp", | ||
| ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026,api-esp", |
There was a problem hiding this comment.
To improve maintainability and reduce the risk of errors during future certificate rotations, it's best to avoid hardcoding the year-specific certificate name. A better approach would be to parameterize this value. Adding a TODO comment here, referencing the original issue, will help track this technical debt and guide future developers.
# TODO(b/492252963): Parameterize the certificate name to simplify future rotations.
ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026,api-esp",
juliawu
left a comment
There was a problem hiding this comment.
Thank you for the updates!
Issue
b/492252963
Related PRs
1547