Skip to content

Update backup multi-domain cert references to reissued cert#1809

Merged
juliawu merged 1 commit intodatacommonsorg:masterfrom
nick-nlb:ssl-cert-2026
Mar 12, 2026
Merged

Update backup multi-domain cert references to reissued cert#1809
juliawu merged 1 commit intodatacommonsorg:masterfrom
nick-nlb:ssl-cert-2026

Conversation

@nick-nlb
Copy link
Contributor

@nick-nlb nick-nlb commented Mar 12, 2026

Issue

b/492252963

Related PRs

1547

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the references to a multi-domain certificate across various environment configurations. The change ensures that the systems correctly point to the newly reissued certificate, maintaining secure communication and preventing service disruptions that could arise from an expired or outdated certificate reference.

Highlights

  • Certificate Reference Update: Updated the pre-shared-cert annotation in Helm chart environment configurations from multi-domain-2025 to multi-domain-2026 to reflect a reissued multi-domain certificate.
Changelog
  • deploy/helm_charts/envs/mixer_autopush.yaml
    • Updated the pre-shared-cert annotation to reference the multi-domain-2026 certificate.
  • deploy/helm_charts/envs/mixer_prod.yaml
    • Updated the pre-shared-cert annotation to reference the multi-domain-2026 certificate.
  • deploy/helm_charts/envs/mixer_staging.yaml
    • Updated the pre-shared-cert annotation to reference the multi-domain-2026 certificate.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the multi-domain certificate reference from multi-domain-2025 to multi-domain-2026 across the autopush, prod, and staging environments. The changes are correct and align with the goal of updating the reissued certificate.

The suggestions to mark the hardcoded certificate names as technical debt and parameterize these values in the Helm chart are valid and will improve long-term maintainability and simplify future certificate rotations. The TODO comments will help track this for future improvement.

annotations:
{
ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2025",
ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce the risk of errors during future certificate rotations, it's best to avoid hardcoding the year-specific certificate name. A better approach would be to parameterize this value. Adding a TODO comment here, referencing the original issue, will help track this technical debt and guide future developers.

      # TODO(b/492252963): Parameterize the certificate name to simplify future rotations.
      ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026",

annotations:
{
ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2025,api-esp",
ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026,api-esp",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce the risk of errors during future certificate rotations, it's best to avoid hardcoding the year-specific certificate name. A better approach would be to parameterize this value. Adding a TODO comment here, referencing the original issue, will help track this technical debt and guide future developers.

      # TODO(b/492252963): Parameterize the certificate name to simplify future rotations.
      ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026,api-esp",

annotations:
{
ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2025,api-esp",
ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026,api-esp",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce the risk of errors during future certificate rotations, it's best to avoid hardcoding the year-specific certificate name. A better approach would be to parameterize this value. Adding a TODO comment here, referencing the original issue, will help track this technical debt and guide future developers.

      # TODO(b/492252963): Parameterize the certificate name to simplify future rotations.
      ingress.gcp.kubernetes.io/pre-shared-cert: "mixer-certificate,multi-domain-2026,api-esp",

@nick-nlb nick-nlb requested a review from juliawu March 12, 2026 21:14
Copy link
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates!

@juliawu juliawu enabled auto-merge March 12, 2026 21:16
@juliawu juliawu added this pull request to the merge queue Mar 12, 2026
Merged via the queue into datacommonsorg:master with commit 12b4ddc Mar 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants