refactor(query): first check privilege in SystemEngine get_full_data #16421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
dosubot
bot
added
A-query
TCeason
commented
Sep 9, 2024
5 tasks
drmingdrmer
added a commit
to drmingdrmer/databend
that referenced
this pull request
Sep 9, 2024
`mget_id_value_compat([names])` fetch a list of `name->id->value` from meta-service with exact 2 mget() operations. This method can be used to optimize batch get operations. For example to get a list of `(DatabaseNameIdent, DatabaseId, DatabaseMeta)`. This method requires the id type to be a `Id<xxxId>` type. - Part of datafuselabs#16421
drmingdrmer
added a commit
to drmingdrmer/databend
that referenced
this pull request
Sep 9, 2024
`mget_id_value_compat([names])` fetch a list of `name->id->value` from meta-service with exact 2 mget() operations. This method can be used to optimize batch get operations. For example to get a list of `(DatabaseNameIdent, DatabaseId, DatabaseMeta)`. This method requires the id type to be a `Id<xxxId>` type. - Part of datafuselabs#16421
TCeason
force-pushed
the
optimize_system
branch
from
c95b1c3
to
0706eb9
Compare
TCeason
changed the title
github-actions
bot
added
the
pr-refactor
drmingdrmer
added a commit
that referenced
this pull request
Sep 9, 2024
`mget_id_value_compat([names])` fetch a list of `name->id->value` from meta-service with exact 2 mget() operations. This method can be used to optimize batch get operations. For example to get a list of `(DatabaseNameIdent, DatabaseId, DatabaseMeta)`. This method requires the id type to be a `Id<xxxId>` type. - Part of #16421
TCeason
force-pushed
the
optimize_system
branch
4 times, most recently
from
ee2fc51
to
523e73b
Compare
TCeason
force-pushed
the
optimize_system
branch
from
523e73b
to
2f36862
Compare
drmingdrmer
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Reviewed 10 of 17 files at r2, 3 of 5 files at r3, all commit messages.
Reviewable status: 12 of 19 files reviewed, all discussions resolved
dosubot
bot
added
size:XL
|
Cc @wubx You can test show columns with this optimize. |
b41sh
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Optimize:
in system table engine , we can only get database that current user can be visibility.
Tests
Type of change
This change is