-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong order by result #16422
Merged
Merged
fix: wrong order by result #16422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Sep 9, 2024
dosubot
bot
added
A-planner
Area: planner/optimizer
C-bug
Category: something isn't working
labels
Sep 9, 2024
xudong963
force-pushed
the
fix_order_by
branch
7 times, most recently
from
September 14, 2024 04:29
0d938ce
to
e0f9dcb
Compare
xudong963
force-pushed
the
fix_order_by
branch
from
September 14, 2024 04:30
e0f9dcb
to
ba2ed55
Compare
xudong963
force-pushed
the
fix_order_by
branch
from
September 14, 2024 08:35
0d410ab
to
8435089
Compare
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
A-query
Area: databend query
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Sep 14, 2024
xudong963
force-pushed
the
fix_order_by
branch
from
September 14, 2024 14:48
74c42d1
to
44384aa
Compare
sundy-li
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
The root cause of wrong order by result is the invalid binding sequence of
order by
andselect
select
, as known asbind_projection
first, then bind order by.RulePushDownSortEvalScalar
to push down sort under eval sort in lazy materialization sceneEliminateEvalScalar
, delete unnecessary eval scalarPushDownSortScan
to make sort push down scan if the SQL pattern issort->eval scalar -> scan
.Tests
Type of change
This change is