refactor: add DatabaseMeta.gc_in_progress #16464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
dosubot
bot
added
the
size:M
TCeason
reviewed
Sep 18, 2024
| /// Indicates whether garbage collection is currently in progress for this dropped database. | ||
| /// | ||
| /// If it is in progress, the database should not be un-dropped, because the data may be incomplete. | ||
| pub gc_in_progress: bool, |
There was a problem hiding this comment.
It means all dbs in old version this flag is false?
Because these dbs are not in progress.
There was a problem hiding this comment.
Yes, Currently no db is in gc state, this new state will be set only when the gc is started. And current codebase does not use this state.
ZhiHanZ
approved these changes
Sep 18, 2024
TCeason
approved these changes
Sep 19, 2024
drmingdrmer
force-pushed
the
142-fix-16433-0
branch
2 times, most recently
from
50ece24
to
84d4f20
Compare
dosubot
bot
added
size:L
drmingdrmer
force-pushed
the
142-fix-16433-0
branch
3 times, most recently
from
256d203
to
d02481b
Compare
If `gc_in_progress` is set, no un-drop can be done on this database. Because the related data may already have been deleted. This commit does not use this flag yet, and will be used in next commit. - Part of datafuselabs#16433
drmingdrmer
force-pushed
the
142-fix-16433-0
branch
from
d02481b
to
cf11f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: add DatabaseMeta.gc_in_progress
If
gc_in_progressis set, no un-drop can be done on this database.Because the related data may already have been deleted.
This commit does not use this flag yet, and will be used in next commit.
Tests
Type of change
Related Issues
This change is