Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): null first behavior #16475

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Sep 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Add settings default_order_by_null defaults to nulls_last.

PG and snowflake use default value nulls_last_on_asc_first_on_desc.

If we change the default value to nulls_last_on_asc_first_on_desc, it's the same as PG but incompatible with the previous version.

  1. Also fix a bug in stats from external parquet file.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 19, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 19, 2024
@dosubot dosubot bot added A-query Area: databend query C-bug Category: something isn't working labels Sep 19, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 20, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 20, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 20, 2024
@BohuTANG BohuTANG merged commit ed39081 into datafuselabs:main Sep 20, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query C-bug Category: something isn't working lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants