Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eliminate union optimizer rule #16478

Merged
merged 4 commits into from
Sep 20, 2024
Merged

feat: add eliminate union optimizer rule #16478

merged 4 commits into from
Sep 20, 2024
+173 −0

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Sep 19, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 19, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 19, 2024
@dosubot dosubot bot added A-planner Area: planner/optimizer C-feature Category: feature labels Sep 19, 2024
@xudong963 xudong963 marked this pull request as draft September 19, 2024 14:57
@xudong963 xudong963 marked this pull request as ready for review September 19, 2024 17:24
Dousir9
Dousir9 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@Dousir9 Dousir9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 20, 2024
@Dousir9 Dousir9 added this pull request to the merge queue Sep 20, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 20, 2024
@BohuTANG BohuTANG merged commit fdd7d3b into datafuselabs:main Sep 20, 2024
81 checks passed
@xudong963 xudong963 deleted the eliminate_union branch September 20, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

Assignees
No one assigned
Labels
A-planner Area: planner/optimizer C-feature Category: feature lgtm This PR has been approved by a maintainer pr-feature this PR introduces a new feature to the codebase size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Databend Query Planner
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xudong963 @Dousir9 @BohuTANG