-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(OpenAPI v3): Improve generic scroll API to have advanced pagination and facets #14877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhixuanjia
wants to merge
10
commits into
datahub-project:master
Choose a base branch
from
zhixuanjia:enhance-scroll-id
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3144564
to
c1d1dc3
Compare
c1d1dc3
to
f9e5c2f
Compare
a2db484
to
1c720a6
Compare
Bundle ReportChanges will decrease total bundle size by 3.53kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1c720a6
to
8227a2a
Compare
237c900
to
7327bab
Compare
60a6f61
to
566805a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
devops
PR or Issue related to DataHub backend & deployment
needs-review
Label for PRs that need review from a maintainer.
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements on generic scroll API in OpenAPI v3
scrollId
is now provided for each entity in the response. This enables backward pagination (scroll backward) and scroll from any position.Test