Skip to content

docs: reference field-path-spec-v2 in SchemaFieldPath #15477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deepgarg760 merged 2 commits into from
Dec 5, 2025
Merged

docs: reference field-path-spec-v2 in SchemaFieldPath #15477

deepgarg760 merged 2 commits into from
Dec 5, 2025

Conversation

@libvarun
Copy link
Contributor

@libvarun libvarun commented Dec 4, 2025

Removes stale TODO in test_serialized_value.py

Addresses TODOs:

  • Links to field-path-spec-v2 docs in SchemaFieldPath.pdl.
  • Cleans up stale TODO in test_serialized_value.py (assertion is correct for JSON schema_type).

Verified: pytest unit tests pass, gradle test clean. No deps changed.

@varunpatil578
docs: reference field-path-spec-v2 in SchemaFieldPath
50c1edc 
Removes stale TODO in test_serialized_value.py
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 4, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 4, 2025
@deepgarg760 deepgarg760 self-requested a review December 4, 2025 10:20
@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Dec 4, 2025
@deepgarg760 deepgarg760 enabled auto-merge (squash) December 4, 2025 11:02
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Dec 4, 2025

Bundle Report

Bundle size has no change ✅

@deepgarg760 deepgarg760 merged commit 697be41 into datahub-project:master Dec 5, 2025
107 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepgarg760 deepgarg760 deepgarg760 approved these changes

Assignees

No one assigned

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community depot ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@libvarun @deepgarg760 @varunpatil578